Changeset 69

Timestamp:

05/06/08 17:20:49 (8 months ago)

Author:

scott

Message:

Fixed about menu and nicklist issues with quit

• quit wasn't removing users from the nicklist, fixed
• "About editor" label changed to "about"

Location:

trunk/Curses-UI-POE

Files:

• examples/irc_client (modified) (2 diffs)
• t/session.t (modified) (3 diffs)

trunk/Curses-UI-POE/examples/irc_client

@@ -73 +73 @@
 
         printf "--- %s (%s) quit \"%s\"", $nick, $hostmask, $_[ARG1];
+
+        $Curses->dropnick($nick);
     },
 
@@ -218 +220 @@
             { -label => 'Help', 
               -submenu => [
-                { -label => 'About editor', -value => \&about_dialog }
+                { -label => 'about', -value => \&about_dialog }
               ]
             }, 

trunk/Curses-UI-POE/t/session.t

@@ -6 +6 @@
 use warnings FATAL => "all";
 
-use Test::Simple tests => 4;
+#use Test::Simple tests => 4;
+use Test;
+BEGIN {
+    plan tests => 4;
+}
+
+# I realize skip is supposed to be conditional, but I don't want the test to
+# run as normal and I do want it to be reported as skipped.  This test doesn't
+# work worth a damn in perl 5.006 and lesser.
+if ($] < 5.008) {
+    skip(1,"_start");
+    skip(1,"yield");
+    skip(1,"_stop");
+    skip(1,"exit");
+
+    exit;
+}
 
 BEGIN {
-    open OLDERR, ">&", \*STDERR;
-    open OLDOUT, ">&", \*STDOUT;
+    if ($] >= 5.008) {
+        open OLDERR, ">&", \*STDERR;
+        open OLDOUT, ">&", \*STDOUT;
 
-    open STDOUT, ">>", "/dev/null";
-    open STDERR, ">>", "/dev/null";
+        open STDOUT, ">>", "/dev/null";
+        open STDERR, ">>", "/dev/null";
+    }
 }
 
@@ -20 +38 @@
 my $cui = new Curses::UI::POE inline_states => {
     _start => sub {
-        open STDOUT, ">>&=", \*OLDOUT;
-        open STDERR, ">>&=", \*OLDERR;
+        if ($] >= 5.008) {
+            open STDOUT, ">>&=", \*OLDOUT;
+            open STDERR, ">>&=", \*OLDERR;
+        }
 
         ok("_start");
@@ -35 +55 @@
     _stop => sub {
         ok("_stop");
-        open STDOUT, ">>", "/dev/null";
-        open STDERR, ">>", "/dev/null";
+
+        if ($] >= 5.008) {
+            open STDOUT, ">>", "/dev/null";
+            open STDERR, ">>", "/dev/null";
+        }
     },
 }, -no_output => 1; # Lotta good -no_output does..